gnu arm64 #28
Open
gnu arm64 #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erueat
requested changes
Dec 6, 2021
| -fwide-exec-charset=UTF-16LE | ||
| -m64 | ||
| ) | ||
| IF(${MAPBAR_PLATFORM} STREQUAL "gnu_arm64") |
Collaborator
There was a problem hiding this comment.
这是一个开源项目，不应使用 MAPBAR_PLATFORM 这样的变量。
| -m64 | ||
| ) | ||
| ENDIF() | ||
|
|
Collaborator
There was a problem hiding this comment.
上面两段文字，其实 x64 版本 跟 arm64 版本的差别只是是否要带 -m64，应该把 -m64 跟其他的分离开来单独处理，避免重复代码。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt to arm64 platform